jmx-dev Codereview request: 8023954 MBean*Info.equals: throw NPE

[shanliang]

Hi,

Still need OK from a code reviewer, thanks Daniel for the review.

Web: http://cr.openjdk.java.net/~sjiang/jdk-8023954/01/
Bug: https://bugs.openjdk.java.net/browse/JDK-8023954

Thanks,
Shanliang

P.S.
The bug id is 8023954, not 8023529, I put the wrong bug ID in the 
previous mails.

Shanliang wrote:
> Daniel Fuchs wrote:
>> On 9/6/13 1:24 PM, shanliang wrote:
>>> Hi,
>>>
>>> Thanks to review the following fix:
>>>
>>> webrev: http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8023954
>>>
>>> Shanliang
>>>
>>
>> Hi Shanliang,
>>
>> Looks good - but it looks as if some hashCode() will suffer from the
>> same issue (for instance MBeanOperationInfo.hashCode)
>>
>> Do you have an other defect to track that?
> We have another bug JDK-8023669 and thank you for having done the code 
> review :) I am waiting a reviewer's review for push the fix
>>
>> I have to wonder why we allow to create an MBeanOperationInfo
>> with a null name though... I wished the first implementation
>> had thrown NPE at construction time.
> I had same wondering, but I had no intention to modify it because that 
> is related to the specification.
> The class OpenMBeanOperation does refuse a null or empty class name.
>
> Shanliang
>>
>> -- daniel
>