RR(S): JDK-7133122 SA throws sun.jvm.hotspot.debugger.UnmappedAddressException when it should not
David Holmes
david.holmes at oracle.com
Wed Sep 18 20:51:30 PDT 2013
Seems okay.
One nit: existed_map -> existing_map
David
On 16/09/2013 6:58 PM, Dmitry Samersoff wrote:
> Staffan,
>
> Thank you! Fixed (in-place).
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
>
> -Dmitry
>
> On 2013-09-16 10:04, Staffan Larsen wrote:
>> A couple of small nits:
>>
>> line 721: there is a superfluous + sign at the beginning of the line.
>>
>> line 729: confliction -> conflict
>>
>> line 734: to -> with
>>
>> line 735: overwrite to -> overwrote with
>>
>>
>> Otherwise looks good.
>>
>> /Staffan
>>
>> On 15 sep 2013, at 15:59, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:
>>
>>> Hi Everybody,
>>>
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-7133122/webrev.01/
>>>
>>> Please review the small fix. This patch was contributed by Yasumasa Suenaga.
>>>
>>> -Dmitry
>>>
>>> --
>>> Dmitry Samersoff
>>> Oracle Java development team, Saint Petersburg, Russia
>>> * I would love to change the world, but they won't give me the sources.
>>
>
>
More information about the serviceability-dev
mailing list