RFR (S): 6313383: SA: Update jmap to support HPROF binary format "JAVA PROFILE 1.0.2"

[Fredrik Arvidsson]

Hi

<quote>
     I assume that you have tested that the resulting dump is readable 
by tools such as visualvm or eclipse MAT?
</quote>

I used MAT to test the result of large and small heap dumps after my 
change. I could successfully parse and read heap files larger than 2Gb 
which is the current threshold for using 1.0.2 format. I also ran dumps 
using lower thresholds to provoke use of the 1.0.2 format for smaller 
heaps several times with success.

/F

On 2013-09-20 16:27, Staffan Larsen wrote:
> Fredrik,
>
> This looks good!
>
> I assume that you have tested that the resulting dump is readable by 
> tools such as visualvm or eclipse MAT?
>
> I very much dislike silent exit of the tests in general. In this case 
> that will happen if it can't find a signed jmap binary on OS X. 
> Unfortunately, I don't have a better solution, other than hope that 
> the test framework would allow us to log such things as some other 
> status than FAILURE or SUCCESS.
>
> Thanks,
> /Staffan
>
> On 20 sep 2013, at 14:35, Fredrik Arvidsson 
> <fredrik.arvidsson at oracle.com <mailto:fredrik.arvidsson at oracle.com>> 
> wrote:
>
>> Hi
>>
>> Please help me and review the changes below:
>>
>> Webrev:http://cr.openjdk.java.net/~allwin/farvidss/6313383/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eallwin/farvidss/6313383/webrev.00/>
>> Bug:https://bugs.openjdk.java.net/browse/JDK-6313383 
>> <https://bugs.openjdk.java.net/browse/JDK-6313383>
>>
>> This change adds support for dumping large heaps (> 4G) using jmap by 
>> implementing the "JAVA PROFILE 1.0.2" file format with segmented heap 
>> dump records.
>> The HPROF binary format specification can be found here: 
>> https://java.net/downloads/heap-snapshot/hprof-binary-format.html.
>>
>> I added a simple test to verify that heaps smaller than 2G are dumped 
>> using the "JAVA PROFILE 1.0.1" format. The last section in the test, 
>> aiming to test the format used when dumping heaps larger than 2G, is 
>> commented out since the test system didn't like that kind of heap 
>> sizes and ultimately failed (OOM and sometimes timeout). The test 
>> should be reintroduced once we can reliably support such tests in the 
>> test system.
>>
>> Thanks 'allwin' for hosting my review :)
>>
>> Cheers
>> /Fredrik
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130920/b37ed822/attachment.html