RFR: 6696975: JTop plugin fails if connected readonly to target JVM

Michel Trudeau michel.trudeau at oracle.com
Fri Sep 20 15:01:44 PDT 2013


Can we get someone to review Erik's latest changes below ?   We need to close this issue.

Thanks,
Michel

On Aug 19, 2013, at 11:25 AM, Erik Gahlin <erik.gahlin at oracle.com> wrote:

Still need a (r)eviewer ok to proceed - can I ask for this please?

Here is the latest change:
http://cr.openjdk.java.net/~egahlin/6696975_2/

Thanks
Erik

Erik Gahlin skrev 2013-08-06 20:53:
> Please review this change.
> 
> ThreadMXBean#setThreadCpuTimeEnabled(true) assumes read-write access to the underlying JVM, but if read-access is only available plug-in will fail and throw an exception.
> http://monaco.us.oracle.com/detail.jsf?cr=6696975
> 
> Unexpected exceptions occurring in JConsole are taken care of by 6696970, but plug-in should still handle read-only access gracefully, as it today does if functionality is not supported by JVM. This can be important if plug-in is used by other programs.
> 
> Webrev:
> http://cr.openjdk.java.net/~egahlin/6696975/
> 
> A sponsor is needed
> 
> Thanks
> Erik




More information about the serviceability-dev mailing list