RR:(M): JDK-8025250 Sync linux and bsd versions of ps_core file

Staffan Larsen staffan.larsen at oracle.com
Mon Sep 23 11:07:15 PDT 2013


On 23 sep 2013, at 10:35, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:

> Staffan,
> 
> On 2013-09-23 21:32, Staffan Larsen wrote:
>> Looks good! Thanks for doing this cleanup. I wish we could get rid of one the files.
> 
> I plan to merge these files and place it to agent/os/nix/ . This cleanup
> is the first step.

Great.

/Staffan


> 
> -Dmitry
> 
>> 
>> Thanks,
>> /Staffan
>> 
>> 
>> On 23 sep 2013, at 08:50, Dmitry Samersoff <Dmitry.Samersoff at oracle.com> wrote:
>> 
>>> Please, review a changes.
>>> 
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8025250/webrev.01/
>>> 
>>> Problem:
>>> 
>>> agent/os/linux/ps_core.c and agent/os/bsd/ps_core.c has lots of common
>>> code but this code has different indentation, bracketing, comments etc.
>>> 
>>> Solution:
>>> 
>>> sync formatting between these two files to simplify further maintenance
>>> 
>>> 
>>> -- 
>>> Dmitry Samersoff
>>> Oracle Java development team, Saint Petersburg, Russia
>>> * I would love to change the world, but they won't give me the sources.
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the sources.



More information about the serviceability-dev mailing list