RR(S): JDK-8022616 u4 should not be used as a type for thread_id

[Yumin Qi]

Dmitry,

   Looks good. Minor comments:
  os_bsd.cpp:

+ #elif __APPLE__ //XNU kernel
+   // despite the fact mach port is actually not a thread id use it
+   // instead of syscall(SYS_thread_selfid) as it certenly fit to u4

Is it  a typo for 'certainly' here?
certenly => certainly
fit => fits

Thanks
Yumin

On 9/24/2013 12:57 AM, Dmitry Samersoff wrote:
> Please review changes:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8022616/webrev.02/
>
> Story:
>
> Tracing framework expect u4 as an id of thread
>
> pthread_t chosen as a tread id for variety of BSD platforms couldn't be
> converted to u4 so it cause compilation failure on BSD x64
>
> Solution:
>
> Change thread_id to pid_t and get this id  directly from kernel, the
> same manner as Linux code does. Mac Os X still uses mach_port instead of
> thread id.
>
> Tested on FreeBSD and OpenBSD and also code passed jprt.
>
> -Dmitry
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20130924/833b1984/attachment.html