Fwd: RR:(M): JDK-8025250 Sync linux and bsd versions of ps_core file
Dmitry Samersoff
dmitry.samersoff at oracle.com
Thu Sep 26 11:58:02 PDT 2013
Yumin,
Thank you!
-Dmitry
On 2013-09-26 22:25, yumin.qi at oracle.com wrote:
> Hi, Dmitry
>
> Changes looks good. A minor comment for comment:
>
> agent/src/os/bsd/ps_core.c:233
> Please remove the trailing "For"
> agent/src/os/linux/ps_core.c:232
> Please remove the trailing "For"
>
> Thanks
> Yumin
>
>
>
> On 9/25/2013 12:14 AM, Dmitry Samersoff wrote:
>> Yumin,
>>
>> Could you take a look?
>>
>> -Dmitry
>>
>>
>> -------- Original Message --------
>> Subject: RR:(M): JDK-8025250 Sync linux and bsd versions of ps_core file
>> Date: Mon, 23 Sep 2013 19:50:00 +0400
>> From: Dmitry Samersoff<dmitry.samersoff at oracle.com>
>> To: serviceability-dev at openjdk.java.net
>>
>> Please, review a changes.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8025250/webrev.01/
>>
>> Problem:
>>
>> agent/os/linux/ps_core.c and agent/os/bsd/ps_core.c has lots of common
>> code but this code has different indentation, bracketing, comments etc.
>>
>> Solution:
>>
>> sync formatting between these two files to simplify further maintenance
>>
>>
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
More information about the serviceability-dev
mailing list