RFR: 8031766: jstatd nightly tests failing with Expected one jstatd process, got 2. Test will be canceled.

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Fri Apr 4 13:32:22 UTC 2014


Looks fine.
You might add a small performance improvement by taking out the regex 
out of the loop at line 99 (compile the pattern before starting the loop).

-JB-

On 4.4.2014 15:25, Yekaterina Kantserova wrote:
> Hi,
>
> Could I please have a review of this fix.
>
> webrev: http://cr.openjdk.java.net/~ykantser/8031766/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8031766
>
> The bug is not visible. But short summary is as follows.
> sun/tools/jstatd/TestJstatdPort.java, TestJstatdPortAndServer.java,
> TestJstatdServer.java have been failing because they expect only one
> jstad process running. I've added a unique identifier for the jstad
> process tests start. So the tests will no more care about how many other
> jstad processes are running.
>
> Thanks,
> Katja



More information about the serviceability-dev mailing list