RFR: 8031766: jstatd nightly tests failing with Expected one jstatd process, got 2. Test will be canceled.

[Staffan Larsen]

Looks good!

Thanks,
/Staffan

On 4 apr 2014, at 16:02, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:

> Thanks, Jaroslav!
> Please find the new webrev here: http://cr.openjdk.java.net/~ykantser/8031766/webrev.01/
> 
> // Katja
> 
> 
> 
> On 04/04/2014 03:32 PM, Jaroslav Bachorik wrote:
>> Looks fine.
>> You might add a small performance improvement by taking out the regex out of the loop at line 99 (compile the pattern before starting the loop).
>> 
>> -JB-
>> 
>> On 4.4.2014 15:25, Yekaterina Kantserova wrote:
>>> Hi,
>>> 
>>> Could I please have a review of this fix.
>>> 
>>> webrev: http://cr.openjdk.java.net/~ykantser/8031766/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8031766
>>> 
>>> The bug is not visible. But short summary is as follows.
>>> sun/tools/jstatd/TestJstatdPort.java, TestJstatdPortAndServer.java,
>>> TestJstatdServer.java have been failing because they expect only one
>>> jstad process running. I've added a unique identifier for the jstad
>>> process tests start. So the tests will no more care about how many other
>>> jstad processes are running.
>>> 
>>> Thanks,
>>> Katja
>> 
>