RFR: 8039432 demo/jvmti/mtrace/TraceJFrame.java can't connect to X11

[Staffan Larsen]

Thanks to both of you!

On 25 apr 2014, at 14:49, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:

> Also looks good which give you a (R)eview...
> 
> Dan
> 
> 
> On 4/25/14 12:54 AM, Markus Grönlund wrote:
>> Looks good Staffan.
>> 
>> Unfortunately I can only do (r)eview.
>> 
>> /Markus
>> 
>> -----Original Message-----
>> From: Staffan Larsen
>> Sent: den 25 april 2014 08:19
>> To: serviceability-dev at openjdk.java.net serviceability-dev at openjdk.java.net
>> Subject: Re: RFR: 8039432 demo/jvmti/mtrace/TraceJFrame.java can't connect to X11
>> 
>> Can I have a Review of this small change, please?
>> 
>> /Staffan
>> 
>> On 8 apr 2014, at 11:04, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>> 
>>> This test causes exceptions that looks like this:
>>> 
>>> java.awt.AWTError: Can't connect to X11 window server using 'REDACTED:503' as the value of the DISPLAY variable.
>>> 	at sun.awt.X11GraphicsEnvironment.initDisplay(Native Method)
>>> 	at sun.awt.X11GraphicsEnvironment.access$200(X11GraphicsEnvironment.java:65)
>>> 	at sun.awt.X11GraphicsEnvironment$1.run(X11GraphicsEnvironment.java:115)
>>> 	at java.security.AccessController.doPrivileged(Native Method)
>>> 	at sun.awt.X11GraphicsEnvironment.<clinit>(X11GraphicsEnvironment.java:74)
>>> 	at java.lang.Class.forName0(Native Method)
>>> 	at java.lang.Class.forName(Class.java:259)
>>> 	at java.awt.GraphicsEnvironment.createGE(GraphicsEnvironment.java:102)
>>> 	at java.awt.GraphicsEnvironment.getLocalGraphicsEnvironment(GraphicsEnvironment.java:81)
>>> 	at TraceJFrame.main(TraceJFrame.java:39)
>>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>>> 	at java.lang.reflect.Method.invoke(Method.java:484)
>>> 	at com.sun.javatest.regtest.MainAction$SameVMRunnable.run(MainAction.java:754)
>>> 	at java.lang.Thread.run(Thread.java:744)
>>> 
>>> 
>>> The fix seems to be to not call GraphicsEnvironment.getLocalGraphicsEnvironement().isHeadlessInstance() but GraphicsEnvironment.isHeadless() directly.
>>> 
>>> Please review the fix below,
>>> 
>>> Thanks,
>>> /Staffan
>>> 
>>> 
>>> 
>>> diff --git a/test/demo/jvmti/mtrace/TraceJFrame.java b/test/demo/jvmti/mtrace/TraceJFrame.java
>>> --- a/test/demo/jvmti/mtrace/TraceJFrame.java
>>> +++ b/test/demo/jvmti/mtrace/TraceJFrame.java
>>> @@ -36,7 +36,7 @@
>>> 
>>> public class TraceJFrame {
>>>     public static void main(String args[]) throws Exception {
>>> -        if (GraphicsEnvironment.getLocalGraphicsEnvironment().isHeadlessInstance()) {
>>> +        if (GraphicsEnvironment.isHeadless()) {
>>>             System.out.println("JFrame test was skipped due to headless mode");
>>>         } else {
>>>             DemoRun demo;
>