RFR: 8033104 sun/jvmstat/monitor/MonitoredVm/CR6672135.java failing on all platforms

[Daniel D. Daugherty]

Looks like when the bug was filed Oracle internal information like
hostnames were included in the description section. You can edit
it out, but that doesn't remove it from the history so the entire
bug has to be marked confidential...

We've updated our internal wikis to let folks know that they should
put non-Oracle-internal info in the description and then add a separate
note for the configuration info with the access level set to "screening
required" or "confidential". Getting everyone on the same page is slow
process...

Dan


On 4/25/14 9:16 AM, Staffan Larsen wrote:
> Thanks Keith!
>
> As far as I can tell there was no good reason for making the bug 
> Confidential, but I can’t undo it. Sorry about that.
>
> /Staffan
>
> On 25 apr 2014, at 17:02, Keith McGuigan <kmcguigan at twitter.com 
> <mailto:kmcguigan at twitter.com>> wrote:
>
>> Hi Staffan -
>>
>> It looks good to me.  Why is the bug marked "closed" though?
>>
>>
>> On Fri, Apr 25, 2014 at 8:56 AM, Staffan Larsen 
>> <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
>>
>>     Still looking for a Review of this change.
>>
>>     Thanks,
>>     /Staffan
>>
>>     On 7 apr 2014, at 21:19, Staffan Larsen
>>     <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
>>
>>     > And the links:
>>     >
>>     > bug: https://bugs.openjdk.java.net/browse/JDK-8033104
>>     > webrev: http://cr.openjdk.java.net/~sla/8033104/webrev.00/
>>     <http://cr.openjdk.java.net/%7Esla/8033104/webrev.00/>
>>     >
>>     > Sorry about that,
>>     > /Staffan
>>     >
>>     > On 7 apr 2014, at 20:08, Staffan Larsen
>>     <staffan.larsen at oracle.com <mailto:staffan.larsen at oracle.com>> wrote:
>>     >
>>     >>
>>     >> The problem here is that the code for finding local VMs is not
>>     looking for the data in the correct place.
>>     >>
>>     >> When a JVM is started it will create the perf-data file in a
>>     user-specific directory inside /tmp (*). The code in the JDK
>>     (PerfDataFile.java) that lists all active JVMs looks for the
>>     user-specific directory inside java.io.tmpdir. If a user sets
>>     -Djava.io.tmpdir on the command line, the code in PerfDataFile
>>     will look in the wrong place.
>>     >>
>>     >> (*) It's a little bit more complex. /tmp is used on Linux and
>>     Solaris. On OS X and Windows, there are user-specific temp
>>     directories that should be used, and so the VM queries the OS for
>>     these paths.
>>     >>
>>     >> The solution would be for PerfDataFile to use the same
>>     locations as the VM creates them in. The simplest way to
>>     guarantee that the same directory is used is to ask the VM to
>>     provide the location. Thus I have introduced a new JVM_ function:
>>     JVM_GetTemporaryDirectory.
>>     >>
>>     >> (Since this change touches both hotspot and jdk repos I will
>>     submit the hotspot part first under a different bug id (provided
>>     that the review goes well)).
>>     >>
>>     >> The newly added test starts two VM with all possible
>>     combinations of setting and not setting java.io.tmpdir to verify
>>     that the mechanism is indeed not looking at that variable. I also
>>     removed an if-statement in BasicTests.java which would have found
>>     this issue a long time ago had it not been there.
>>     >>
>>     >> Thanks,
>>     >> /Staffan
>>     >
>>
>>
>>
>>
>> -- 
>> twitter-icon-large.png
>> 	
>> Keith McGuigan
>> @kamggg
>> kmcguigan at twitter.com <mailto:kmcguigan at twitter.com>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140425/08331393/attachment-0001.html>