RFR (S) 7187999: dtrace jstack action is broken

[David Holmes]

Hi Serguei,

This seems reasonable. One nit:

  355         $(DTRACE_PROG) $(DTRACE_OPTS) -C -I. -G -o $@ -s 
$(DTRACE_JHELPER).d

There should be a $(QUIETLY) in front of that.

Also the copyright year needs updating.

Thanks,
David

On 1/08/2014 10:29 AM, serguei.spitsyn at oracle.com wrote:
> Please, review the fix for:
>    https://bugs.openjdk.java.net/browse/JDK-7187999
>
>
> Open webrev:
> http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/7187999-dtrace.1
>
>
> Summary:
>
>    The DTrace jstack action support was broken for several years.
>    The issue came when the build flag -Xlazyload was added by request
> from the Solaris team.
>    This flag was necessary to resolve a performance issue.
>    The jstack action stopped working as the jhelper.d was loaded lazily
> as well.
>
>    The idea of this fix was suggested by Junsang Cho from the Solaris team.
>    The jhelper.d and hotspot probes (other USDT scripts) are separated
> into two different SUNW_DOF sections.
>    Now the jhelper.d is built without the -Xlazyload flag.
>
> Testing:
>    Running the adhoc dtrace tests on Solaris sparcv9 and amd64
>
>
> Thanks,
> Serguei