RFR (S) 7187999: dtrace jstack action is broken

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Fri Aug 1 08:41:49 UTC 2014


Dmitry,

I'll add a part of the comment into make file.

Thank you for the review!
Serguei


On 8/1/14 1:25 AM, Dmitry Samersoff wrote:
> Serguei,
>
> Looks good for me.
>
> Could you put comments below into makefile?
>
> -Dmitry
>
> On 2014-08-01 04:29, serguei.spitsyn at oracle.com wrote:
>> Please, review the fix for:
>>    https://bugs.openjdk.java.net/browse/JDK-7187999
>>
>>
>> Open webrev:
>> http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/7187999-dtrace.1
>>
>>
>> Summary:
>>
>>    The DTrace jstack action support was broken for several years.
>>    The issue came when the build flag -Xlazyload was added by request
>> from the Solaris team.
>>    This flag was necessary to resolve a performance issue.
>>    The jstack action stopped working as the jhelper.d was loaded lazily
>> as well.
>>
>>    The idea of this fix was suggested by Junsang Cho from the Solaris team.
>>    The jhelper.d and hotspot probes (other USDT scripts) are separated
>> into two different SUNW_DOF sections.
>>    Now the jhelper.d is built without the -Xlazyload flag.
>>
>> Testing:
>>    Running the adhoc dtrace tests on Solaris sparcv9 and amd64
>>
>>
>> Thanks,
>> Serguei
>



More information about the serviceability-dev mailing list