RFR(S): JDK-8031583: warnings from b03 for hotspot/agent/src/os/solaris/proc: JNI exception pending

[Staffan Larsen]

On 12 aug 2014, at 15:03, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:

> Staffan,
> 
> On 2014-08-12 15:10, Staffan Larsen wrote:
>> Dmitry,
>> 
>> Since CHECK_EXCEPTION just returns if there was an exception, you
>> will get no information that an exception happened or that there was
>> an error looking up the exception class. I am not sure how this helps
>> (other than get rid of a static analysis warning).
> 
> It's a common pattern in agent code. So this fix just make the code
> uniform and yes it fixes static analysis warning.

OK then because it fixes the warning and that the particular class will always be present.

Reviewed.

/Staffan

> 
> -Dmitry
> 
> 
>> 
>> /Staffan
>> 
>> On 11 aug 2014, at 16:57, Dmitry Samersoff
>> <dmitry.samersoff at oracle.com> wrote:
>> 
>>> Hi Everybody,
>>> 
>>> Please, review small fix that adds more exception handling code
>>> 
>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8031583/webrev.01/
>>> 
>>> -Dmitry
>>> 
>>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg,
>>> Russia * I would love to change the world, but they won't give me
>>> the sources.
>> 
> 
> 
> -- 
> Dmitry Samersoff
> Oracle Java development team, Saint Petersburg, Russia
> * I would love to change the world, but they won't give me the source code.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140812/1c5be378/attachment.html>