RFR (M): 8054278: Refactor jps utility tests

[Staffan Larsen]

It should work. Most of the test in jdk/test/com/sun/jdi uses "@run driver” and runs well with 4.1 fcs b09.

/Staffan


On 14 aug 2014, at 14:16, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:

> Opps, it doesn't seem we can use "@run driver" with jtreg 4.1 b09. I get following error:
> 
> ...
>  * @build jdk.testlibrary.* JpsHelper JpsBase
>  * @run driver TestJpsClass
> ...
> TEST: sun/tools/jps/TestJpsClass.java
> TEST RESULT: Error. Bad action for script: driver
> ...
> 
> // Katja
> 
> 
> 
> On 08/14/2014 02:07 PM, Yekaterina Kantserova wrote:
>> Leonid,
>> 
>> Yes, it seems to be a good idea. I'll check how it works.
>> 
>> // Katja
>> 
>> 
>> On 08/14/2014 01:55 PM, Leonid Mesnik wrote:
>>> Katya
>>> 
>>> I am not reviewing tests, just have small comment.
>>> I think it would be better to use '@run driver' instead of '@run main' in these tests. 
>>> 
>>> Leonid
>>> 
>>> On 14.08.2014 15:40, Yekaterina Kantserova wrote:
>>>> Hi,
>>>> 
>>>> Could I please have a review of this fix.
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~ykantser/8054278/webrev.00/
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8054278
>>>> 
>>>> As of today the test/jdk/sun/tools/jps tests are a number of shell and awk scripts that test only a few combinations of jps args. The tests also used to fail intermittently due to timing issues, e.g. JDK-7091195 and JDK-6542634. In order to make tests more stable and make sure all combinations of arguments are tested the test will be refactored using jdk.testlibrary functionality.
>>>>           
>>>> The tests have been run on all basic platforms.
>>>> 
>>>> Thanks,
>>>> Katja
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140814/874b6ddc/attachment-0001.html>