RFR(XS): 8055012 - [TESTBUG] NMTHelper fails to parse NMT output

olivier.lagneau at oracle.com olivier.lagneau at oracle.com
Mon Aug 18 11:39:23 UTC 2014


Hi Christian,

Looks good !

Olivier.
On 15/08/2014 16:55, Christian Tornqvist wrote:
>
> Hi,
>
> This is a small update to NMTHelper.java to make it work with recent 
> changes in the NMT implementation that changed the output format a bit.
>
> I’ve tested the change locally using 
> java\lang\instrument\RedefineBigClass.sh and 
> java\lang\instrument\RetransformBigClass.sh
>
> Webrev doesn’t seem to like whitespace-only changes so I can’t post a 
> webrev, I’m pasting the diff here instead:
>
> diff -r 362a6ea9bc84 test/java/lang/instrument/NMTHelper.java
>
> --- a/test/java/lang/instrument/NMTHelper.java  Thu Aug 14 15:54:04 
> 2014 -0700
>
> +++ b/test/java/lang/instrument/NMTHelper.java  Fri Aug 15 10:43:15 
> 2014 -0400
>
> @@ -32,8 +32,8 @@
>
>          executeDcmd("vmNativeMemory", "baseline");
>
>      }
>
> -    // Total:  reserved=3484685KB  +293KB, committed=266629KB +293KB
>
> -    private static Pattern totalLine = Pattern.compile("^Total:  
> reserved=\\d+KB  .*KB, committed=\\d+KB (.*)KB$");
>
> +    // Total: reserved=3484685KB +293KB, committed=266629KB +293KB
>
> +    private static Pattern totalLine = Pattern.compile("^Total: 
> reserved=\\d+KB .*KB, committed=\\d+KB (.*)KB$");
>
>      public static long committedDiff() throws Exception {
>
>          String res = (String) executeDcmd("vmNativeMemory", 
> "detail.diff");
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8055012
>
> Thanks,
>
> Christian
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140818/ebf0b837/attachment-0001.html>


More information about the serviceability-dev mailing list