RFR(S), SA, warnings from b116 for hotspot.agent.src.share.native: JNI exception pending

[serguei.spitsyn at oracle.com]

Dmitry,

It is good in general modulo Staffan's comments.

There are some inconsistencies:
  -  the ExceptionOccurred(env) is compared to != NULL (which make the 
logic more complex)
      in some places and no such comparison (implicit comparison 
instead) in others
  - two different forms of check/action are used:
       - (*env)->ExceptionOccurred(env) and
       - !(*env)->ExceptionOccurred(env)

I'd suggest to do it the same way and always return the "default" value 
if an exception occurred.
It will make the logic more flat and clear.
Otherwise, we have to think what exact value is returned in exception 
occurred cases like at lines 241, 255.

The comment // OOM is used inconsistently too.


Thanks,
Serguei


On 12/2/14 11:14 AM, Dmitry Samersoff wrote:
> Please review the small fix.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8028773/webrev.01/
>
> Added more missed exception checks to sadis.c
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20141202/0c4d3c62/attachment-0001.html>