RFR(S): 8067030 JDWP crash in transport_startTransport on OOM

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue Dec 9 22:30:00 UTC 2014


Hi Dmitry,

The fix looks good.

However, there are a couple of more places in that file
where the result of the jvmtiAllocate() is not checked:

   68         utf8msg = (jbyte*)jvmtiAllocate(maxlen+1);

  393     buf = jvmtiAllocate(len*3+3);


Could you fix this as well?


Thanks,
Serguei


On 12/9/14 11:50 AM, Dmitry Samersoff wrote:
> Hi Everybody,
>
> Please review small fix.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/
>
> JDWP crash if allocation fails because it calls strcpy before
> check of allocation results.
>
> -Dmitry
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20141209/8d6bb680/attachment-0001.html>


More information about the serviceability-dev mailing list