RFR(S): 6977426: sun/tools tests can intermittently fail to find app's Java pid

Yekaterina Kantserova yekaterina.kantserova at oracle.com
Wed Dec 17 07:52:26 UTC 2014


Hi Daniel,

Thank you for reviewing the fix! That's what 'vm.heapHisto("-live")' 
does - it will request a full GC.

Best regards,
Katja



On 12/16/2014 06:37 PM, Daniel Fuchs wrote:
> Hi Katja,
>
> Nice too see some more shell scripts go away!
>
> I wonder - shouldn't the test force a System.gc()
> at some point before taking the histogram?
>
> If not what guarantee do we have that the various weak references
> will be purged?
>
> best regards,
>
> -- daniel
>
> On 16/12/14 16:57, Yekaterina Kantserova wrote:
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-6977426
>> webrev: http://cr.openjdk.java.net/~ykantser/6977426/webrev.00/
>>
>> java/util/logging/LoggerWeakRefLeak.sh and
>> java/util/logging/AnonLoggerWeakRefLeak.sh are merged and rewritten in
>> java. sun/tools/common/CommonTests.sh is removed because it doesn't test
>> the product but sun/tool/common library functionality.
>>
>> Thanks,
>> Katja
>



More information about the serviceability-dev mailing list