Need Second reviewer! Re: RR(S): JDK-8023667 SA: ExceptionBlob and other C2 classes not available in client VM

[David Holmes]

Hi Dmitry,

This looks okay to me.

But can I suggest not starting a new email thread when you need to 
prompt for reviews as it makes this review disconnected from the 
original RFR email. (I would have replied to the original but I don't 
have a local copy to do that.)

Thanks,
David

On 5/02/2014 11:45 PM, Dmitry Samersoff wrote:
> On 2014-02-04 17:46, Dmitry Samersoff wrote:
>> Staffan,
>>
>> You was right, only two classes is C2 specific.
>>
>> Here is updated webrev.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8023667/webrev.02/
>>
>> -Dmitry
>>
>> On 2014-02-03 16:13, Staffan Larsen wrote:
>>>
>>> On 3 feb 2014, at 11:59, Dmitry Samersoff <dmitry.samersoff at oracle.com> wrote:
>>>
>>>> Staffan,
>>>>
>>>> All items under try-catch exists only in server (C2 compiler) VM, so if
>>>> one of them is missing in target VM other items is missed as well.
>>>
>>> Are you sure? Some of them look very generic: “JavaThread”, “SurrogateLockerThread”, “GenCollectedHeap”, etc. Perhaps the catch-ignore-c2-specifics should end at lin 821?
>>>
>>> /Staffan
>>>
>>>
>>>>
>>>> I have no ideas what happens later if SA tries to access one of this
>>>> non-initialized items, but I don't see any errors in my home testing.
>>>>
>>>> -Dmitry
>>>>
>>>> On 2014-02-03 14:39, Staffan Larsen wrote:
>>>>> It looks like this new version will leave some things uninitialized
>>>>> if an item higher on the list throws an exception. I don’t think that
>>>>> is what you want.
>>>>>
>>>>> /Staffan
>>>>>
>>>>>
>>>>> On 31 jan 2014, at 20:42, Dmitry Samersoff
>>>>> <dmitry.samersoff at oracle.com> wrote:
>>>>>
>>>>>> Hi Everybody,
>>>>>>
>>>>>> Please review the fix:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8023667/webrev.01/
>>>>>>
>>>>>> sa.js try to initialize all possible VM structures regardless of
>>>>>> type of VM we are running on
>>>>>>
>>>>>> -- Dmitry Samersoff Oracle Java development team, Saint Petersburg,
>>>>>> Russia * I would love to change the world, but they won't give me
>>>>>> the sources.
>>>>>
>>>>
>>>>
>>>> --
>>>> Dmitry Samersoff
>>>> Oracle Java development team, Saint Petersburg, Russia
>>>> * I would love to change the world, but they won't give me the sources.
>>>
>>
>>
>
>