8034856/8034857: More gcc warnings

[Dmitry Samersoff]

Mikael,

> http://cr.openjdk.java.net/~mikael/webrevs/isspace/webrev.00/webrev/

1. I agree that ctypes isspace usually cause more problems than solve
and it's good to have our own version.

2. one of possible implementation is

 #define isspaceASCII(c) (strchr(SPACE_CHARS,c) != NULL)

-Dmitry


On 2014-02-18 07:59, Mikael Vidstedt wrote:
> 
> On 2014-02-17 07:08, Alan Bateman wrote:
>> On 17/02/2014 05:51, Mikael Vidstedt wrote:
>>>
>>> I'm inclined to agree with this. Since the code depends on a specific
>>> behavior of isspace which does not match what the system provided
>>> function does I too think it would be more robust to implement our
>>> own version of it.
>> I completely agree that changing this code to use its own isspace is
>> the right thing, it just seems a bit much for a drive-by fixed to gcc
>> warnings. Do either of you want to take it?
> 
> How about:
> 
> http://cr.openjdk.java.net/~mikael/webrevs/isspace/webrev.00/webrev/
> 
> Cheers,
> Mikael
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.