Codereview request: 8035195 demo/jvmti/mtrace/TraceJFrame.java can't connect to X11

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Thu Feb 20 00:47:10 PST 2014


On 20.2.2014 09:05, Staffan Larsen wrote:
> Looks like an OK change although it does not fix the issue with test failures that we see. For that, someone in SQE needs to look at the environment and make sure the tests is run correctly.
>
> I suggest you leave the current bug open and create a new one for this test output change.
+1

-JB-

>
> /Staffan
>
> On 19 feb 2014, at 09:17, shanliang <shanliang.jiang at oracle.com> wrote:
>
>> Hi,
>>
>> The failure was from a bad DISPLAY setting, this must be not intended, so we re-throw the exception and tell to make sure that the DISPLAY is correct.
>>
>> The fix is only to add a catch of InternalError at the beginning, the rest code is not modified but re-formated to remove some spaces.
>>
>> webrev:
>> http://cr.openjdk.java.net/~sjiang/JDK-8035195/00 <http://cr.openjdk.java.net/%7Esjiang/JDK-8035195/00>/
>>
>> bug:
>> https://bugs.openjdk.java.net/browse/JDK-8035195
>>
>>
>> Thanks,
>> Shanliang
>



More information about the serviceability-dev mailing list