RFR(XS): JDK-8034867 - Object references from expression stack are not visible as roots via jvmti FollowReferences and HeapDump

[Staffan Larsen]

On 24 feb 2014, at 09:39, Volker Simonis <volker.simonis at gmail.com> wrote:

> Hi Serguei,
> 
> thanks a lot for sponsoring this change.
> 
> It seems that https://bugs.openjdk.java.net/browse/INTJDK-7609362 is
> not visible.
> Could you please make it readable for everybody.

Since it is filed on an internal test suite it’s not possible to make the bug visible to everyone.

/Staffan

> 
> Thank you and best regards,
> Volker
> 
> 
> On Mon, Feb 24, 2014 at 8:32 AM, serguei.spitsyn at oracle.com
> <serguei.spitsyn at oracle.com> wrote:
>> The fix has been integrated into the jdk9/hs-rt repo.
>> 
>> I've also filed a qe-test/hotspot Enhancement to integrate the test
>> attached to the bug report into the VM SQE test base:
>>  https://bugs.openjdk.java.net/browse/INTJDK-7609362
>> 
>> Thanks,
>> Serguei
>> 
>> 
>> 
>> On 2/20/14 12:04 PM, serguei.spitsyn at oracle.com wrote:
>>> 
>>> Hi Axel,
>>> 
>>> We decided that I will sponsor your change.
>>> My current plan is to test and push it over weekend.
>>> 
>>> Thanks,
>>> Serguei
>>> 
>>> 
>>> On 2/20/14 1:05 AM, Siebenborn, Axel wrote:
>>>> 
>>>> Yes, I need a sponsor for this change.
>>>> Thanks for the reviews,
>>>> Axel
>>>> 
>>>> 
>>>>> -----Original Message-----
>>>>> From: Volker Simonis [mailto:volker.simonis at gmail.com]
>>>>> Sent: Donnerstag, 20. Februar 2014 09:21
>>>>> To: serguei.spitsyn at oracle.com
>>>>> Cc: Coleen Phillimore; hotspot-runtime-dev at openjdk.java.net;
>>>>> serviceability-dev at openjdk.java.net; Siebenborn, Axel
>>>>> Subject: Re: RFR(XS): JDK-8034867 - Object references from expression
>>>>> stack
>>>>> are not visible as roots via jvmti FollowReferences and HeapDump
>>>>> 
>>>>> Axel is covered by the SAP OCA.
>>>>> 
>>>>> Thanks,
>>>>> Volker
>>>>> 
>>>>> 
>>>>> On Thu, Feb 20, 2014 at 6:30 AM, serguei.spitsyn at oracle.com
>>>>> <serguei.spitsyn at oracle.com> wrote:
>>>>>> 
>>>>>> It looks good to me too.
>>>>>> But does Axel need to sign an OCA ?
>>>>>> 
>>>>>> This is a link to follow:
>>>>>>   http://openjdk.java.net/contribute/
>>>>>> 
>>>>>> 
>>>>>> Thanks,
>>>>>> Serguei
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> On 2/19/14 11:28 AM, Coleen Phillimore wrote:
>>>>>> 
>>>>>> 
>>>>>> This change looks good.  Do you need a sponsor?
>>>>>> thanks,
>>>>>> Coleen
>>>>>> 
>>>>>> On 2/13/14 11:57 AM, Siebenborn, Axel wrote:
>>>>>> 
>>>>>> Hi all,
>>>>>> 
>>>>>> could I have a review for the following change?
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> It adds code to iterate over the slots of the expression stack.
>>>>>> 
>>>>>> Found object references are used as heap roots, the same way as object
>>>>>> references in locals slots.
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Bug:
>>>>>> 
>>>>>> https://bugs.openjdk.java.net/browse/JDK-8034867
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Webrev:
>>>>>> 
>>>>>> http://sapjvm.com/as/webrevs/8034867
>>>>>> 
>>>>>> 
>>>>>> 
>>>>>> Thanks,
>>>>>> 
>>>>>> Axel
>>>>>> 
>>>>>> 
>>>>>> 
>>> 
>>