RR(S): 8028623 and 8032466: serviceability agent hashcode changes.
Kevin Walls
kevin.walls at oracle.com
Tue Feb 25 01:54:31 PST 2014
Hi -
I'm going to backport this (8028623 hashcode change, and testcase tweak
8032466) to jdk8u (and after that, to jdk7u). The same changesets work
and test fine.
8u webrev, planning to push to
http://hg.openjdk.java.net/jdk8u/hs-dev/hotspot:
http://cr.openjdk.java.net/~kevinw/8028623/8028623.8u.001/
This email is a further review/request, or if that is redundant it's
just a warning in case anybody thinks that is a bad idea for some
reason. Feel free to speak, but I would rather like to presume the same
reviewers are OK with it...
Thanks
Kevin
On 23/01/14 09:16, Kevin Walls wrote:
> Thanks Dmitry, Staffan!
>
> On 23/01/14 07:05, Staffan Larsen wrote:
>> Looks good!
>>
>> Thanks,
>> /Staffan
>>
>> On 22 jan 2014, at 18:43, Kevin Walls <kevin.walls at oracle.com> wrote:
>>
>>> Hi,
>>>
>>> Can I just get a review of this jtreg tag change in a testcase. The
>>> testcase specifically contains a utf8 character and to make sure it
>>> compiles everywhere we need to specify -encoding on the @compile
>>> line, and then add an @run line:
>>>
>>> webrev
>>> http://cr.openjdk.java.net/~kevinw/8032466/webrev.00/
>>>
>>> bug
>>> https://bugs.openjdk.java.net/browse/JDK-8032466
>>>
>>> (if the testcase runs fine without this change, in jtreg locally you
>>> can make it fail by setting -encoding ascii)
>>>
>>> Thanks!
>>> Kevin
>
More information about the serviceability-dev
mailing list