jmx-dev [ping] Re: RFR 8022221: Intermittent test failures in sun/management/jmxremote/startstop/JMXStartStopTest.sh

[Staffan Larsen]

Looks good! And very sorry for letting this slip.

Thanks,
/Staffan

On 14 jan 2014, at 14:13, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:

> Thanks, Staffan!
> 
> On 14.1.2014 13:13, Staffan Larsen wrote:
>> JMXStartStopTest.java:162
>> I see no path that calls testConnect with port == -1, so can we we remove the setting of port to 4567? I don’t like that hardcoded port, and I don’t see it being used.
> 
> I've removed the port setting magic - now the testConnect(...) needs to be called with the requested port number.
> 
> Also, there are some minor changes in the webrev due to merging.
> 
> Updated webrev: http://cr.openjdk.java.net/~jbachorik/8022221/webrev.01
> 
> Cheers,
> 
> -JB-
> 
>> 
>> Other than that I think it looks good.
>> 
>> /Staffan
>> 
>> On 14 jan 2014, at 12:27, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:
>> 
>>> Ok, trying again. Could anyone, please, spare some time to review this test stabilization fix?
>>> 
>>> Thanks!
>>> 
>>> -JB-
>>> 
>>> On 17.12.2013 12:41, Jaroslav Bachorik wrote:
>>>> Anyone?
>>>> 
>>>> -JB-
>>>> 
>>>> On 15.11.2013 15:25, Jaroslav Bachorik wrote:
>>>>> Please, review this test fix.
>>>>> 
>>>>> Issue : https://bugs.openjdk.java.net/browse/JDK-8022221
>>>>> Webrev: http://cr.openjdk.java.net/~jbachorik/8022221/webrev.00
>>>>> 
>>>>> The test was facing intermittent failures due to not 100% failproof
>>>>> interprocess synchronization using lock files. The solution is rewriting
>>>>> the shell test to pure Java and use stdout/stderr processing for the
>>>>> application started by the test to assess its status.
>>>>> 
>>>>> A part of the change is also few improvements to the
>>>>> jdk.testlibrary.ProcessTools.
>>>>> 
>>>>> Thanks,
>>>>> 
>>>>> -JB-
>>>> 
>>> 
>> 
>