RFR(XS) 6545321: jstatLineCounts4.sh has to be resilient to unexpected output

Dmitry Samersoff dmitry.samersoff at oracle.com
Wed Jan 22 04:49:32 PST 2014


Mattias,

We don't use totallines anymore so need not to increment it:

 { totallines++; print $0 }

otherwise looks good.

-Dmitry


On 2014-01-21 16:32, Mattias Tobiasson wrote:
> Hi,
> Could you please review this test fix. The current test is unstable and fails intermittently.
> 
> The test parses output from jstat.
> It verifies number of header lines, data lines and total lines.
> The test sometimes fails because there are unexpected debug output from the jvm, which means that total line count does not match.
> 
> The fix is to ignore total line count, and only verify header lines and data lines.
> There are multiple tests with the same problem. All have been fixed, even if the bug only mentions one test.
> 
> bug:
> https://bugs.openjdk.java.net/browse/JDK-6545321
> 
> webrev:
> http://cr.openjdk.java.net/~ykantser/6545321/webrev.00/
> 
> Mattias
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list