Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

[Dmitry Samersoff]

Hi Everyone,

Please review the fix.

http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.02/

-Dmitry

On 2014-01-20 20:00, Dmitry Samersoff wrote:
> Hi Everyone,
> 
> Please review the fix.
> 
> http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.01/
> 
> This fix doesn't solve all problems with symbol lookup in SA, but
> address the problem mentioned in bug reports.
> 
> 1. I change algorithm of pathmap_open. Now, it tries to find library
> hardly.
> 
> 2. I decided not to fix broken binary search in loadObjectContainingPC,
> because with less then 20 DSO's we typically have here performance of
> just linear search is approx the same as load, sort, convert to array
> and do binary search.
> 
> -Dmitry
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.