RFR 8031701: java/lang/management/ThreadMXBean/Locks.java: Thread WaitingThread is expected to wait on Object but got null Thread.State = RUNNABLE

[Jaroslav Bachorik]

Hi Mandy,

On 29.1.2014 00:50, Mandy Chung wrote:
> Hi Jaroslav,
>
> On 1/21/14 7:50 AM, Jaroslav Bachorik wrote:
>> Please, review the following test fix.
>>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8031701
>> Webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.00
>>
>
> The change looks okay.  I like the new assertNoLock method and as you
> indicate in the comment in L54-55 that the thread state is dummy and not
> verified, would it worth refactor checkBlockedObject?  The comment "//
> #blocking#1", "// #waiting#1", etc are little confusing - maybe "phase
> 1", "phase 2", etc?

I've simplified checkBlockedObject() and modified the comments - I'm 
using "#phase#w#1" and "#phase#b#1" to distinguish between the phases 
during testing blocking and waiting.

>
> line 279 - leftover comment can be removed.  Since you are here, can you
> add a space after "==" in line 68 "==Thread.State.BLOCKED"

Fixed.

Updated webrev: http://cr.openjdk.java.net/~jbachorik/8031701/webrev.02

Thanks,

-JB-

>
> thanks
> Mandy