RFR(M): 8028474: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.sh timeout, leaves looping process behind

roger riggs roger.riggs at oracle.com
Tue Jul 1 12:35:07 UTC 2014


Hi Erik,

Consider switching to System.nanoTime;  it is not sensitive to clock changes
and avoids leaving a land mine that may cause a spurious non-repeatable 
test failure.
'Deducing it from the log' means there is a failure and creates probably 
an hour or two of work
for some quality engineer and burns a couple of hours re-running the 
test run.

Roger



On 7/1/2014 3:37 AM, Erik Gahlin wrote:
>
>
>> JavaProcess.waitForRemoval: How about using timestamps 
>> (currentTimeMillis()) before the loop and for each ite
>> ration to determine if the timeout has expired (instead of "time+=100”)?
>>
> The code now uses currentTimeMillis(). Premature timeouts due to clock 
> changes can be deduced from the log.
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140701/3a453fa9/attachment-0001.html>


More information about the serviceability-dev mailing list