RFR(S): 8049340: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java timed out

[Erik Gahlin]

Hi,

I'm generally in favor of looping forever, but for this test it doesn't 
work since the test spawns child processes. Here is an updated version 
that forwards the system property.

http://cr.openjdk.java.net/~egahlin/8049340_3/

I avoided Utils.TIMEOUT_FACTOR, since it would mean passing the 
testlibrary on the class path, making the test more complex.

Thanks
Erik

Jaroslav Bachorik skrev 2014-07-07 10:23:
> Hi Erik,
>
> I have a comment regarding the test timeout - you should scale the 
> timeout according to "test.timeout.factor" system property set by 
> JTReg (you can use "jdk.testlibrary.Utils.TIMEOUT_FACTOR" to access it 
> easily) to prevent intermittent timeouts on slow configurations. Or 
> you could completely omit the timeout and loop forever, relying on the 
> harness to timeout the test.
>
> Other than that the change looks fine.
>
> Cheers,
>
> -JB-
>
> On 07/06/2014 06:53 PM, Erik Gahlin wrote:
>> Hi,
>>
>> Could I have a review of a small test fix.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~egahlin/8049340_1/
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8049340
>>
>> Testing:
>> 100 iterations locally
>> 25 iterations locally under high load (CPU > 95%)
>> 5 JPRT runs
>>
>> L226-229:
>> If the file is removed by the test process before Files.exist statement
>> is reached in the child process
>> an Error is thrown. The test will pass without this change, but it makes
>> log easier to read.
>>
>> L244:
>> Use println instead of print.
>>
>> L292-299:
>> The actual problem, see comment in file.
>>
>> L312:
>> Typo, should be "stderr" instead of "stder"
>>
>> Thanks
>> Erik
>