RFR(S): JDK-8049046 Deprecated Function in hotspot/src/os/solaris/vm/attachListener_solaris.cpp

[David Holmes]

Hi Dmitry,

On 26/07/2014 7:46 PM, Dmitry Samersoff wrote:
> Please,
>
> Review the small fix.
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8049046/webrev.01/
>
> door_cred() is deprecated since Solaris 11.2 so replace it to door_ucred()

11.2? door_cred has been marked obsolete since before that file started 
using it (if we can believe the copyright date)! :)

      The door_cred() function is  obsolete.  Applications  should
      use the door_ucred(3DOOR) function in place of door_cred().

ATTRIBUTES
      See attributes(5) for descriptions of the  following  attri-
      butes:

SunOS 5.10          Last change: 25 Mar 2003                    1
                                 -------------


Change looks okay to me. A minor style nit - I dislike int variables 
that pretend to be booleans, I'd prefer

int ok

be simply

int ret

Cheers,
David
------

> Testing:
>
> JPRT
>