RFR(S): 8043915: Tests get ClassNotFoundException: com.oracle.java.testlibrary.StreamPumper

[Yekaterina Kantserova]

Peter, thanks for your review! See my comments inlined.

On 05/30/2014 02:08 PM, Peter Allwin wrote:
> Hi Katja,
>
> Is it necessary to @build classes used in @run statements? I see you added it to some but GetObjectSizeOverflow.java is missing ClassFileInstaller.

No it is not. Here is an explanation from Jon:
"The class specified in an "@run main" directive is subject to an 
implicit "@build" meaning that it will be compiled if needed."
But it does no harm and my intention was to change as little as possible.

New webrev can be found here: 
http://cr.openjdk.java.net/~ykantser/8043915/webrev.01/

Thanks,
Katja

>
>
> Other than that it looks good!
>
> Thanks,
> /peter
>
>
> On 28 May 2014, at 13:58, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>
>> Hi,
>>
>> Could I please have a review of this fix.
>>
>> webrev: http://cr.openjdk.java.net/~ykantser/8043915/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8043915
>>
>> When using @library in a JTreg test even @build need to be specify for all library files used by the test. If @build is not specified it can lead to intermittent failures when for example running tests concurrently, since javac implicit compilation and @library and -concurrency don't play well together.
>>
>> Verified locally.
>>
>> Thanks,
>> Katja