RFR: 8036006 [TESTBUG] sun/tools/native2ascii/NativeErrors.java: Process exit code was 0, but error was expected

[David Holmes]

+1

David

On 2/06/2014 10:14 PM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
> On 2 jun 2014, at 14:11, Mattias Tobiasson <mattias.tobiasson at oracle.com> wrote:
>
>> Hi,
>> Could someone please review this test fix?
>>
>> The test tries to write to a read-only file and expects an error.
>> The test will fail if it is run as root, because root is allowed to write to read-only files.
>>
>> The fix is to check if the file is really read-only with function java.io.File.canWrite().
>> If we are root then canWrite() will return true and the read-only part of the test is skipped.
>>
>> webrev: http://cr.openjdk.java.net/~ykantser/8036006/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8036006
>>
>> Mattias
>>
>