RFR: 8044135 Add API to start JMX agent from attach framework

[Staffan Larsen]

On 10 jun 2014, at 14:07, Daniel Fuchs <daniel.fuchs at oracle.com> wrote:

> Hi Staffan,
> 
> In:
> http://cr.openjdk.java.net/~sla/8044135/webrev.00/src/share/classes/sun/tools/attach/HotSpotVirtualMachine.java.frames.html
> 
> line 190, I wonder whether some escape mechanism should
> be put in place for entry.getValue().
> 
> Do you have the guarantee that entry.getValue() will never contain
> a white space?

Good point. I’ve added some code to put the values in quotes if there are spaces in the values. (I know I could add the quotes always, but it felt more correct to only do it when needed). I also updated the StartManagementAgent test to verify that this works.

webrev: http://cr.openjdk.java.net/~sla/8044135/webrev.03/

Thanks,
/Staffan

> 
> Best regards,
> 
> -- daniel
> 
> On 6/9/14 9:03 PM, Staffan Larsen wrote:
>> This is the first part in a two-part series of removing the management-agent.jar and replacing its functionality with APIs in the attach framework. In this change I have added the new APIs, a later change will remove management-api.jar.
>> 
>> management-agent.jar is the java agent that is used with the attach API to start the JMX agent in a target VM. It's the approach used in JDK 6 to start JMX in a running VM and predates the "jcmd ManagementAgent.start" command added in 7uX.
>> 
>> management-agent.jar will be problematic when we move to a modular JDK in JDK 9 and should be replaced by a "real" API. So this change adds two methods to VirtualMachine in the attach framework for starting either a local or a remote management agent.
>> 
>> webrev: http://cr.openjdk.java.net/~sla/8044135/webrev.00/
>> bug: https://bugs.openjdk.java.net/browse/JDK-8044135
>> 
>> Thanks,
>> /Staffan
>> 
>