RFR: 8044135 Add API to start JMX agent from attach framework

[Staffan Larsen]

On 11 jun 2014, at 14:57, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 11/06/2014 09:08, Staffan Larsen wrote:
>> 
>> I added:
>> 
>> +     * @throws  IllegalArgumentException
>> +     *          If keys or values in agentProperties are invalid.
>> +     *
> That is probably okay for now, thanks.
> 
> 
>> :
>> 
>> I would prefer to leave them in as they do no harm for non-Eclipse users and are only present in the tests.
>> 
> I don't use Eclipse but I will guess that it shouldn't complain if these methods are package-private (just an approach that would avoid suppressing non-javac warnings).

Yes, that works. I will push with that change.

Thanks,
/Staffan



> 
> -Alan