RFR: 8036132 Tab characters in test/com/sun/jdi files

Staffan Larsen staffan.larsen at oracle.com
Mon Mar 3 23:24:45 PST 2014


Missed one more place in CatchPatternTest.sh: http://cr.openjdk.java.net/~sla/8036132/webrev.02/

/Staffan

On 4 mar 2014, at 08:09, Staffan Larsen <staffan.larsen at oracle.com> wrote:

> Thanks for noticing! The same mistake was in all the inlined Java code.
> 
> new webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.01/
> 
> /Staffan
> 
> On 3 mar 2014, at 21:04, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
> 
>> 
>> I randomly chose a file and ended up looking at GetLocalVariables4Test.sh where the indentation of all the lines in main() appear to be off - the tab should have been translated to 8 spaces in this case, not 4?
>> 
>> Cheers,
>> Mikael
>> 
>> On 2014-03-03 05:30, Staffan Larsen wrote:
>>> Just changing a lot of tabs into a lot more spaces. Easiest to view in the patch file.
>>> 
>>> webrev: http://cr.openjdk.java.net/~sla/8036132/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8036132
>>> 
>>> Thanks,
>>> /Staffan
>>> 
>>> 
>> 
> 



More information about the serviceability-dev mailing list