RFR(S): JDK-8035952 Remove use of JVM_Open, JVM_Read and JVM_Close functions from serviceability code

[Frederic Parain]

Oops, I replied to the wrong e-mail.
Your latest comments have been taken into account
in the final changeset.

Thank you,

Fred

On 03/05/2014 11:31 AM, Frederic Parain wrote:
> Thank you for the review Alan.
>
> Fred
>
> On 03/03/2014 10:32 PM, Alan Bateman wrote:
>> On 03/03/2014 10:30, Frederic Parain wrote:
>>> :
>>>
>>> I'd prefer to keep open() and read() as they are,
>>> for the sake of simplicity. In the unlikely case
>>> where one of these calls gets interrupted, it would
>>> simply generate a transient error in the value returned
>>> by OperatingSystem.getCommittedVirtualMemorySize()
>>> with a easily identifiable value of -1.
>> open is okay (as you say, open64 isn't interesting here). On EINTR then
>> open can fail but it seems be just fifos so probably not a concern with
>> /proc. However for read then I think we should handle it (I agree with
>> Martin that it's generally a bug if we don't). I realize it's not a big
>> issue but might be odd for
>> getCommittedVirtualMemorySize be intermittently "not supported" .
>>
>> -Alan
>

-- 
Frederic Parain - Oracle
Grenoble Engineering Center - France
Phone: +33 4 76 18 81 17
Email: Frederic.Parain at oracle.com