RFR 8037274 (Round 0): sun.tools.attach.WindowsVirtualMachine#createPipe() needs more descriptive message when pipe creation fails

Peter Allwin peter.allwin at oracle.com
Thu Mar 13 12:41:28 UTC 2014


Hi Jaroslav,

You could use the FormatMessage function which produces a text message for GetLastError, the os::lasterror function in os_windows.cpp does just that.

Regards,
/peter

On 13 Mar 2014, at 13:29, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:

> Please, take a look at this patch.
> 
> Issue : https://bugs.openjdk.java.net/browse/JDK-8037274
> Webrev: http://cr.openjdk.java.net/~jbachorik/8037274/webrev.00/
> 
> This patch adds an additional info to the error message issued when an attempt to create a named pipe fails. This is supposed to help when identifying the failure cause. The fix is pretty simple but the code I produced might not be exactly aligned with the general C coding style in JDK source base. If you see any violation, please, let me know.
> 
> Thanks!
> 
> -JB-



More information about the serviceability-dev mailing list