RFR 8037274 : sun.tools.attach.WindowsVirtualMachine#createPipe() needs more descriptive message when pipe creation fails

Alan Bateman Alan.Bateman at oracle.com
Fri Mar 14 15:02:02 UTC 2014


On 14/03/2014 14:48, Jaroslav Bachorik wrote:
> Thanks for the Round-0 comments!
>
>
> Please, take a look at the updated patch.
>
> Issue : https://bugs.openjdk.java.net/browse/JDK-8037274
> Webrev: http://cr.openjdk.java.net/~jbachorik/8037274/webrev.02/
>
> The change is about adding the the last error code number to the 
> default provided failure message if FormatMessage() is not able 
> recognize the error code for whatever reason.
GetLastError is a win32 function so I assume this doesn't build on other 
platforms.

Maybe the easiest thing here is to just put the error code into the 
message that WindowsVirtualMachine uses to call ThrowByNameWithLastError.

-Alan




More information about the serviceability-dev mailing list