RFR: 8036786: Update jdk7 testlibrary to match jdk8

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Tue Mar 25 10:40:04 UTC 2014


The lambdas were removed properly. The changes look fine to me. (not a 
reviewer, though).

-JB-

On 25.3.2014 10:45, Mattis Castegren wrote:
> This is becoming URGENT as we have other high priority cases pending the backport of these test libraries.
>
> We could backport these fixes without the tests and then file a separate bug to backport the tests, but it would be great if we could just get a review of this, as it is a pretty straight forward backport
>
> Kind Regards
> /Mattis
>
> -----Original Message-----
> From: Alan Bateman
> Sent: den 14 mars 2014 15:42
> To: Mattis Castegren
> Cc: Vladimir Kempik; core-libs-dev at openjdk.java.net; Ekaterina Medvedeva; serviceability-dev at openjdk.java.net
> Subject: Re: RFR: 8036786: Update jdk7 testlibrary to match jdk8
>
>
> Adding serviceability-dev to the CC list as this seems to be where this
> testlibrary has mostly been developed and maintained.
>
> -Alan.
>
> On 13/03/2014 14:02, Mattis Castegren wrote:
>> Hi
>>
>> Could we have someone review this change. This is just a backport from JDK8, but there were some small changes so we want to get a proper review here.
>>
>> We have several other backports waiting for this change (fixes using the new test libraries), so it would be good to get this going.
>>
>> Kind Regards
>> /Mattis
>>
>> -----Original Message-----
>> From: Vladimir Kempik
>> Sent: den 6 mars 2014 16:34
>> To: core-libs-dev at openjdk.java.net
>> Cc: Mattis Castegren
>> Subject: RFR: 8036786: Update jdk7 testlibrary to match jdk8
>>
>> Please review this change to update jdk part of testlibrary in jdk7.
>>
>> It updates testlibrary with new apis from jdk8's testlibrary.
>>
>> When porting jdk8's testlibrary to jdk7, I had to make few changes:
>>
>> 1) rewrite one lambda usage in StreamPumper.java to non-lambda version.
>>
>> 2) get rid of predicate functionality in ProcessTools.java: startProcess
>> as it wasn't used anyway and unsupported in jdk7.
>>
>> Every test in open part of jdk that uses testlibrary still works after
>> update (in fact there are 3 of them).
>>
>> Webrev:
>> http://cr.openjdk.java.net/~vkempik/8036786/webrev.00/
>>
>> Thanks, Vladimir.
>



More information about the serviceability-dev mailing list