RFR 8038322: CounterMonitorDeadlockTest.java fails intermittently, presumed deadlock

[Daniel Fuchs]

Looks good!

On 5/2/14 1:20 PM, shanliang wrote:
> Daniel Fuchs wrote:
>> Hi Shanliang,
>>
>> This looks reasonable to me.
>> Another possibility could have been to use the timeout factor
>> to adapt the delay of Thread.sleep in the loop.
> Yes we could adapt our timeout, but it is simpler to use the testing
> harness timeout.
>>
>> What you have might be more reliable, but it also means
>> that if the test ever fails in timeout again then it could
>> be more difficult to diagnose what was wrong.
>>
>> Maybe you should add a trace before entering
>> and after leaving any of your two loops, so that you
>> at least will know where the test was being blocked?
> Yes, absolutely useful to add trace:
> http://cr.openjdk.java.net/~sjiang/JDK-8038322/01/
> <http://cr.openjdk.java.net/%7Esjiang/JDK-8038322/01/>
>
> Thanks,
> Shanliang
>>
>> best regards,
>>
>> -- daniel
>>
>> On 5/2/14 11:17 AM, shanliang wrote:
>>> Please review this test fix.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8038322
>>> Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8038322/00/
>>> <http://cr.openjdk.java.net/%7Esjiang/JDK-8038322/00/>
>>>
>>> The test had a timeout of 500*10 ms, better to remove this timeout and
>>> to wait the harness timeout.
>>>
>>> Thanks,
>>> Shanliang
>>
>