RFR: 8027230: Overflow in java.lang.instrument.Instrumentation.getObjectSize() method

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Tue May 20 18:56:53 UTC 2014


Peter,

The fix looks good.
A minor comment on the test:
   - a space is needed after the catch (line 39) and if (line 43)

Thanks,
Serguei

On 5/20/14 8:02 AM, Peter Allwin wrote:
> Hello!
>
> Please review this simple fix for an integer overflow in JVMTI GetObjectSize().
>
> webrev: http://cr.openjdk.java.net/~allwin/8027230/webrev.00/
> cr: https://bugs.openjdk.java.net/browse/JDK-8027230
>
>
> Testing:
> 	New regression test
> 	nsk.quick-jvmti.testlist
>
> Thanks!
> /peter



More information about the serviceability-dev mailing list