RFR: 8039995: Test serviceability/sa/jmap-hashcode/Test8028623.java fails on some Linux/Mac machines.

Dmitry Samersoff dmitry.samersoff at oracle.com
Fri May 23 11:12:28 UTC 2014


Kevin,

It might make sense to check output for

"Error attaching to process:"

regardless to exit code of jmap

and terminate test immediately with appropriate exit code (internally, I
use 7) to distinguish between PASS and ERROR.

-Dmitry


On 2014-05-20 15:14, Kevin Walls wrote:
> Hi - any comments? 8-)
> 
> On 12/05/14 16:02, Kevin Walls wrote:
>>
>> Hi,
>>
>> I'd like to get a review of this test change.  It assumed that jmap
>> would have permission to run on a process that the test itself
>> created, but this is not necessarily the case.
>>
>> Here I'm considering it OK to skip (pass) the test where jmap fails to
>> attach.  The test itself was not platform-specific and as long as we
>> have other platforms where jmap step will work, we are testing for
>> this problem.
>>
>> bug:
>> https://bugs.openjdk.java.net/browse/JDK-8039995
>>
>> webrev:
>> http://cr.openjdk.java.net/~kevinw/8039995/webrev.00/
>>
>> Thanks
>> Kevin
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.


More information about the serviceability-dev mailing list