RFR 8062116: JVMTI GetClassMethods is Slow

[Jeremy Manson]

Weird coincidence.

On Tue, Nov 4, 2014 at 11:57 AM, serguei.spitsyn at oracle.com <
serguei.spitsyn at oracle.com> wrote:

> Hi Jeremy and Coleen,
>
> I'm reviewing this too.
> We also need to run the nsk.jvmti, nsk.jdi and jtreg jdi tests.
>
> Thanks,
> Serguei
>
> On 11/3/14 12:19 PM, Coleen Phillimore wrote:
>
>>
>> Hi Jeremy,
>>
>> I reviewed your new code and it looks fine.  I had one comment in
>>
>> http://cr.openjdk.java.net/~jmanson/8062116/webrev.00/src/
>> share/vm/prims/jvmtiEnv.cpp.udiff.html
>>
>> The name "need_to_resolve" doesn't make sense when reading this code.
>> Isn't it more like "need_to_ensure_space" ?  I think method resolution with
>> the other name, which it doesn't do.
>>
>> I was trying to find a way to make this new code not appear twice (maybe
>> with a local jvmtiEnv function get_jmethodID(m) - instanceK_h is
>> m->method_holder()).
>>
>
> Agreed on the above.
>


Per my message to Coleen, you can't add methods to this file.  All other
possibilities seemed like overkill, but other suggestions welcome.

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20141104/5f00238d/attachment.html>