RFR 8062896: TEST_BUG: java/lang/Thread/ThreadStateTest.java can't compile with change for 8058506

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Wed Nov 5 08:48:38 UTC 2014


On 11/05/2014 09:45 AM, David Holmes wrote:
> On 5/11/2014 6:03 PM, Jaroslav Bachorik wrote:
>> Please, review the following fix
>>
>> Issue : https://bugs.openjdk.java.net/browse/JDK-8062896
>> Webrev: http://cr.openjdk.java.net/~jbachorik/8062896/webrev.00/
>>
>> Unfortunately, JTREG does not allow for automatic building library
>> dependencies from the library classes themselves and therefore the
>> @build section for the transitive closure of the library classes must be
>> specified in all the tests using those library classes.
>
> Ok. But this should be have been detected before the other push was done.

It really depends on the order of execution of the tests :( If 
ThreadMXBeanStateTest is executed before ThreadStateTest the 
LockFreeLogManager class has already been compiled and the test will 
pass. If the order reverts the ThreadStateTest fails with compilation error.

I should have searched for the uses of ThreadStateController more 
thoroughly :(

-JB-

>
> David
>
>> Thanks,
>>
>> -JB-



More information about the serviceability-dev mailing list