RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

[David Holmes]

On 14/11/2014 4:18 AM, Daniel D. Daugherty wrote:
> Magnus,
>
> Thanks for the review!
>
> Replies embedded below...
>
> On 11/13/14 7:44 AM, Magnus Ihse Bursie wrote:
>> On 2014-11-11 01:00, Daniel D. Daugherty wrote:
>>> Greetings,
>>>
>>> I have a Solaris Full Debug Symbols (FDS) fix ready for review.
>>> Yes, it is a small fix, but it is in Makefiles so feel free to
>>> run screaming from the room... :-)  On the plus side the fix does
>>> delete two work around source files (Coleen would say that's a
>>> Good Thing (TM)!)
>>
>> ... but you're only deleting the make files?
>
> Good catch! Looks like when I resurrected this fix from my JDK8
> queue I missed a couple of deletes.
>
>
>> src/os/solaris/add_gnu_debuglink/add_gnu_debuglink.c and
>> src/os/solaris/fix_empty_sec_hdr_flags/fix_empty_sec_hdr_flags.c could
>> be deleted as well, right?
>
> Yes, these should be deleted and I'll do that in this fix.
> Since these are two deletes of files that can no longer be
> built anyway, I presume I don't need to sent out another
> webrev...

I don't need to see an updated webrev :)

Thanks,
David


>
>>
>> Good idea for the fix, anyway. I opened
>> https://bugs.openjdk.java.net/browse/JDK-8064808 to implement a
>> similar solution in configure.
>
> Sounds good to me.
>
> Dan
>
>
>>
>> /Magnus
>