RFR(M): JDK-8041639: Don't link the java_crw_demo shared library from product tools

Mandy Chung mandy.chung at oracle.com
Thu Oct 9 06:22:33 UTC 2014


Hi Dmitry,

On 10/6/2014 12:08 PM, Dmitry Samersoff wrote:
> Hi Everybody,
>
> Please review:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8041639/webrev.01/
>
> The fix moves code from java_crw_demo to libhprof. Also I remove mtrace
> and minst demos that uses java_crw_demo library.
>

Do you really want to remove mtrace and minst demos?  Perhaps
just make a copy of crw.c and crw.h (instead of moving) although
not ideal.  I think you could simply copy the main part of
README_CRW.txt (from line 44) to crw.h and no need to move
that README to hprof source.

Mandy



More information about the serviceability-dev mailing list