RFR(S): JDK-8029465 warnings from b118 for jdk.src.share.native.sun.management: JNI exception pending

[Dmitry Samersoff]

David,

After close look I don't think that Arrays.asList() could throw any
exception here. We are checking for possible null pointer at ll. 74

So I would prefer to leave the code as is.

-Dmitry

On 2014-10-15 04:21, David Holmes wrote:
> Hi Dmitry,
> 
> On 15/10/2014 3:46 AM, Dmitry Samersoff wrote:
>> Please review a small fix:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
>>
>> Added couple of missed exception checks.
> 
> Added checks look fine.
> 
> Am wondering about:
> 
>  104   resultList = (*env)->CallStaticObjectMethod(env, arraysCls, mid,
> result);
>  105   return resultList;
> 
> If there is an exception pending due to the call what will resultList be
> set to? Hopefully NULL but the JNI spec says nothing.
> 
> Thanks,
> David
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.