RFR(S): JDK-8029465 warnings from b118 for jdk.src.share.native.sun.management: JNI exception pending

[Dmitry Samersoff]

David,

Added extra check to be on safe side.

(in place - press shift-reload)

http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/

-Dmitry

On 2014-10-15 12:17, David Holmes wrote:
> On 15/10/2014 5:58 PM, Dmitry Samersoff wrote:
>> David,
>>
>> After close look I don't think that Arrays.asList() could throw any
>> exception here. We are checking for possible null pointer at ll. 74
> 
> I would think OOME is always possible. But it was just a concern - if
> the caller of getDiagnosticCommandArgumentInfoArray checks for
> exceptions before touching the return value, or the return value is
> actually NULL in that case, then it is okay.
> 
> Cheers,
> David
> 
>> So I would prefer to leave the code as is.
>>
>> -Dmitry
>>
http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
>> On 2014-10-15 04:21, David Holmes wrote:
>>> Hi Dmitry,
>>>
>>> On 15/10/2014 3:46 AM, Dmitry Samersoff wrote:
>>>> Please review a small fix:
>>>>
>>>> http://cr.openjdk.java.net/~dsamersoff/JDK-8029465/webrev.01/
>>>>
>>>> Added couple of missed exception checks.
>>>
>>> Added checks look fine.
>>>
>>> Am wondering about:
>>>
>>>   104   resultList = (*env)->CallStaticObjectMethod(env, arraysCls, mid,
>>> result);
>>>   105   return resultList;
>>>
>>> If there is an exception pending due to the call what will resultList be
>>> set to? Hopefully NULL but the JNI spec says nothing.
>>>
>>> Thanks,
>>> David
>>>
>>
>>


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.