RFR(XS): 8056994: sun/tools/jstatd/TestJstatdPortAndServer.java and sun/tools/jstatd/TestJstatdServer.java miss correct check of RMI server availability

Jaroslav Bachorik jaroslav.bachorik at oracle.com
Mon Sep 1 13:47:48 UTC 2014


Hi Katja,

On 09/01/2014 02:04 PM, Yekaterina Kantserova wrote:
> Hi,
>
> Could I please have a review of this small fix.
>
> webrev: http://cr.openjdk.java.net/~ykantser/8056994/webrev.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8056994

I would recommend moving the code from L154-157 before the start of the 
while loop and simplify it with
`String remoteHost = serverName != null ? serverName : "JStatRemoteHost"`

Cheers,

-JB-

>
> Thanks,
> Katja
>



More information about the serviceability-dev mailing list